Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(model): Add linearsvc agent #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

its-sushant
Copy link
Contributor

Description

Added a agent for Linear Support vector machine model.

Files

  • agents/linearsvc.py (Python file to run linearsvc model)

How to use

  • Running linearsvc agent
    atarashi -a linearsvc /path/to/file.c

  • Checking accuracy using evaluator.py
    python3 path/to/evaluator.py -a linearsvc

Accuracy

The accuracy score that has been tested using evaluator.py is 63%

CC: @hastagAB @Kaushl2208 @GMishx @ag4ums @vasudevmaduri

Copy link
Member

@hastagAB hastagAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The agent looks good to me!
Need testing @Kaushl2208

@hastagAB hastagAB added need test enhancement New feature or request GSoC-22 Label to tag issues and pull request for GSoC 2022 activities labels Jul 18, 2022
Copy link
Member

@Kaushl2208 Kaushl2208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chanegs Looks good to me :)

Will Test 👍

@amanjain97
Copy link
Collaborator

@hastagAB I think all PRs should have sphinx updates in them included or have we added this to github workflows ?

@Kaushl2208
Copy link
Member

Tested the PR, Changes seems to be working :)

image

A small thing that we can look at a warning that popped up due to the change in version for unpickling the file with different versions:

image

You can read about it from here: https://scikit-learn.org/stable/model_persistence.html#security-maintainability-limitations

Comments? @its-sushant @hastagAB @GMishx

@Kaushl2208
Copy link
Member

Tested the PR, Changes seems to be working :)

A small thing that we can look at a warning that popped up due to the change in version for unpickling the file with different versions:

You can read about it from here: https://scikit-learn.org/stable/model_persistence.html#security-maintainability-limitations

Comments? @its-sushant @hastagAB @GMishx

Is it happening because of old version of linearsvc being used in linearsvc>=0.1.1 ??

Please try fixing it to a working version using linearsvc==0.1.1 so pickling and unpickling does not cause issues.

@its-sushant
Copy link
Contributor Author

Tested the PR, Changes seems to be working :)
A small thing that we can look at a warning that popped up due to the change in version for unpickling the file with different versions:
You can read about it from here: https://scikit-learn.org/stable/model_persistence.html#security-maintainability-limitations
Comments? @its-sushant @hastagAB @GMishx

Is it happening because of old version of linearsvc being used in linearsvc>=0.1.1 ??

Please try fixing it to a working version using linearsvc==0.1.1 so pickling and unpickling does not cause issues.

@Kaushl2208 Actually the model has been trained on sklearn==1.0.2 and atarashi uses the updated version, that's why it is showing some warning. I need to train the model again with sklearn==1.1.1 then I guess the warning will be gone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GSoC-22 Label to tag issues and pull request for GSoC 2022 activities need test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants