Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(randomBytes): adding support to generate different bytes via RngCore #8996

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat(randomBytes): adding support to generate different bytes via RngCore #8996

wants to merge 6 commits into from
+1,869 −302

Conversation

Abhishekkochar
Copy link

@Abhishekkochar Abhishekkochar commented Oct 1, 2024 •
edited
Loading

fixes #8805

Motivation

Solution

@Abhishekkochar Abhishekkochar marked this pull request as draft October 1, 2024 07:09
@Abhishekkochar Abhishekkochar marked this pull request as ready for review October 1, 2024 09:00
@StackOverflowExcept1on
Copy link
Contributor

Could you also implement vm.randomBytes (fill_bytes)?

@DaniPopes
Copy link
Member

vm.randomBytes already exists

DaniPopes
DaniPopes requested changes Oct 1, 2024
View reviewed changes
crates/cheatcodes/src/utils.rs Outdated Show resolved Hide resolved
testdata/cheats/Vm.sol Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert changes to this file that are not automatically generated.

crates/cheatcodes/spec/src/vm.rs Outdated Show resolved Hide resolved
crates/cheatcodes/spec/src/vm.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaniPopes DaniPopes DaniPopes requested changes

@klkvr klkvr Awaiting requested review from klkvr klkvr is a code owner

@mattsse mattsse Awaiting requested review from mattsse mattsse is a code owner

@grandizzy grandizzy Awaiting requested review from grandizzy grandizzy is a code owner

@yash-atreya yash-atreya Awaiting requested review from yash-atreya yash-atreya is a code owner

@zerosnacks zerosnacks Awaiting requested review from zerosnacks zerosnacks is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Foundry
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(cheatcodes): add vm.random{Bytes, Bytes4, Bytes8}()
3 participants
@Abhishekkochar @StackOverflowExcept1on @DaniPopes