chore(deps): bump alloy to 0.4.0 #9000
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yash-atreya
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
zerosnacks
as code owners
mattsse
reviewed
Oct 1, 2024
| @@ -65,7 +65,7 @@ pub fn transaction_request_to_typed( | |||
| kind: to.unwrap_or_default(), | |||
| mint: other.get_deserialized::<U256>("mint")?.ok()?, | |||
| value: value.unwrap_or_default(), | |||
| gas_limit: gas.unwrap_or_default(), | |||
| gas_limit: gas.map(|g| g as u128).unwrap_or_default(), | |||
There was a problem hiding this comment.
could we instead change this type to u64?
| @@ -1178,14 +1178,14 @@ latest block number: {latest_block}" | |||
| // if not set explicitly we use the base fee of the latest block | |||
| if self.base_fee.is_none() { | |||
| if let Some(base_fee) = block.header.base_fee_per_gas { | |||
| self.base_fee = Some(base_fee); | |||
| self.base_fee = Some(base_fee as u128); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Alloy
0.4.0has been released.Solution
Bump to latest