Pad addresses to correct length #2486
Open
+198
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cptartur
requested review from
ksew1,
integraledelebesgue and
ddoktorski
as code owners
ddoktorski
reviewed
Sep 20, 2024
| @@ -24,6 +26,30 @@ where | |||
| serializer.serialize_str(&format!("{value:#}")) | |||
| } | |||
|
|
|||
| #[derive(Clone, Copy, Debug, PartialEq, Deserialize, CairoSerialize)] | |||
| pub struct Address(pub Felt); | |||
There was a problem hiding this comment.
I'm not a big fan of using the Address name since it is also used for class_hash. Generally without additional context, it could be confusing to understand why it was introduced. Apart from this, I think we should also print transaction_hash with padded 0 for consistency.
CHANGELOG.md
Outdated
| @@ -16,6 +16,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| #### Fixed | |||
|
|
|||
| - `sncast declare` no longer fails for flat contracts (i.e. CASM artifacts with `bytecode_segment_lengths` being a number) | |||
| - Addresses outputted when calling `sncast account create`, `sncast deploy` and `sncast declare` are now padded to the correct length and prefixed with `0x0` | |||
There was a problem hiding this comment.
The term correct length implies that it has been incorrect so far, which I think is not true (but we would need to define what this means first). How about rephrasing it to note that it's now padded with 0 and always 64 characters long?
# Conflicts: # crates/sncast/src/helpers/block_explorer.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2248
Closes #2424
Introduced changes
sncast account create,sncast declareandsncast deployare now correctly padded to 66 (64 after0x) characters length.Checklist
CHANGELOG.md