Skip to content

Commit

Permalink
refactor(test): update repost settings before test case
Browse files Browse the repository at this point in the history
  • Loading branch information
ruthra-kumar committed Dec 12, 2023
1 parent ccff588 commit acb6e8e
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,11 @@ def setUp(self):
self.create_company()
self.create_customer()
self.create_item()
self.update_repost_settings()
update_repost_settings()

def teadDown(self):
frappe.db.rollback()

def update_repost_settings(self):
allowed_types = ["Sales Invoice", "Purchase Invoice", "Payment Entry", "Journal Entry"]
repost_settings = frappe.get_doc("Repost Accounting Ledger Settings")
for x in allowed_types:
repost_settings.append("allowed_types", {"document_type": x, "allowed": True})
repost_settings.save()

def test_01_basic_functions(self):
si = create_sales_invoice(
item=self.item,
Expand Down Expand Up @@ -209,3 +202,11 @@ def test_05_without_deletion_flag(self):

self.assertIsNotNone(frappe.db.exists("GL Entry", {"voucher_no": si.name, "is_cancelled": 1}))
self.assertIsNotNone(frappe.db.exists("GL Entry", {"voucher_no": pe.name, "is_cancelled": 1}))


def update_repost_settings():
allowed_types = ["Sales Invoice", "Purchase Invoice", "Payment Entry", "Journal Entry"]
repost_settings = frappe.get_doc("Repost Accounting Ledger Settings")
for x in allowed_types:
repost_settings.append("allowed_types", {"document_type": x, "allowed": True})
repost_settings.save()
6 changes: 6 additions & 0 deletions erpnext/accounts/doctype/sales_invoice/test_sales_invoice.py
Original file line number Diff line number Diff line change
Expand Up @@ -2793,6 +2793,12 @@ def test_sales_invoice_with_discount_accounting_enabled(self):
@change_settings("Selling Settings", {"enable_discount_accounting": 1})
def test_additional_discount_for_sales_invoice_with_discount_accounting_enabled(self):

from erpnext.accounts.doctype.repost_accounting_ledger.test_repost_accounting_ledger import (
update_repost_settings,
)

update_repost_settings()

additional_discount_account = create_account(
account_name="Discount Account",
parent_account="Indirect Expenses - _TC",
Expand Down

0 comments on commit acb6e8e

Please sign in to comment.