fix: Asset cancelation issue

frappe · May 14, 2024 · fa2b6c4 · fa2b6c4
1 parent e3f5393
commit fa2b6c4
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/erpnext/accounts/doctype/journal_entry/journal_entry.py b/erpnext/accounts/doctype/journal_entry/journal_entry.py
@@ -453,11 +453,12 @@ def unlink_advance_entry_reference(self):
 
 	def unlink_asset_reference(self):
 		for d in self.get("accounts"):
+			root_type = frappe.get_value("Account", d.account, "root_type")
 			if (
 				self.voucher_type == "Depreciation Entry"
 				and d.reference_type == "Asset"
 				and d.reference_name
-				and d.account_type == "Depreciation"
+				and root_type == "Expense"
 				and d.debit
 			):
 				asset = frappe.get_doc("Asset", d.reference_name)