fix: allow nested accounts to be validated with accounting dimensions #41294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
accounts
needs-tests
Alchez
force-pushed
the
fix-accounting-dimension
branch
from
c3320fe
to
0ded850
Compare
|
@deepeshgarg007 @ruthra-kumar can you please have a look and suggest changes? |
Alchez
force-pushed
the
fix-accounting-dimension
branch
3 times, most recently
from
9394354
to
18133c8
Compare
Alchez
force-pushed
the
fix-accounting-dimension
branch
from
18133c8
to
4f471b3
Compare
|
This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
|
This is breaking lots of test cases. Would suggest you rewrite to have the least possible impact. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41212.