Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multiple issues in Payment Request (#42427) #43407

Open
wants to merge 5 commits into
base: version-15-hotfix
Choose a base branch
from

Conversation

Abdeali099
Copy link
Contributor

@Abdeali099 Abdeali099 commented Sep 27, 2024

  • fix: multiple issues in Payment Request

  • chore: minor changes

  • fix: remove bug

  • fix: replace round with flt

  • fix: changes as per review

  • refactor: replace sql query of matched_payment_requests to query builder

  • fix: replace locals with get_doc in set_query

  • fix: changes during review

  • fix: minor review changes

  • fix: remove unnecessary code for setting payment entry received amount

  • fix: logic for set payment_request if PE made from transaction

  • fix: Use rounded total to make Payment Request from Sales Invoice or Purchase Invoice

  • refactor: enhance logic of set_open_payment_requests_to_references

  • fix: added one optional arg created_from_payment_request

  • fix: handle multiple allocation of PR at PE's reference

  • fix: logic for PR if outstanding docs fetch

  • fix: formatted Link field for Payment Request for PE's references

  • fix: replace get_all() with get_list() for getting Payment Request for Link field

  • chore: format payment_entry.js file

  • style: Show preview popup of Payment Request

  • fix: remove minor bug

  • fix: add virtual field for Payment Term and Request outstanding_amount in PE's reference

  • fix: get outstanding amount in PE's reference on realtime

  • fix: move allocation of allocated_amount to server side (no change)

  • fix: some minor changes to allocation

  • fix: Split Payment Request if PE is created from PR and there are Payment Terms

  • fix: minor logic changes

  • fix: Allocation of allocated_amount if paid_amount is changes

  • fix: improve logic of allocation

  • fix: set matched payment request if unset

  • fix: minor changes

  • fix: Allocate single Payment Request if PE created from PR

  • fix: improve code logic

  • fix: Removed duplication code

  • fix: proper message title

  • refactor: Rename method of Allocation Amount to References

  • refactor: Changing grand_total description based on party_type

  • refactor: update Payment Request

  • fix: Remove virtual property of payment_term_outstanding from references

  • fix: fetch party account currency for creating payment request

  • fix: use transaction currency as base in payment request

  • fix: party amount for creating payment entry

  • fix: allow for proportional amount paid by bank

  • fix: Changed field order in Payment Request

  • fix: Minor refactor in Payment Entry Reference table data

  • test: Added test cases for allow Payment at Partially Paid status for PR

  • test: Update partial paid status test case

  • test: Update test case for same currency PR

  • refactor: Wider the msgprint dialog for after save PE

  • test: Update PR test cases

  • chore: Remove dirty lines

  • fix: formatting update

  • fix: Use flt where doing subtraction

  • test: PR test case with Payment Term for same currency

  • fix: remove redundant flt

  • test: Add test cases for PR

* fix: multiple issues in Payment Request

* chore: minor changes

* fix: remove  bug

* fix: replace `round` with `flt`

* fix: update `set_advance_payment_status()` logic

* fix: removed bug of `set_advance_payment_status`

* fix: changes as per review

* refactor: replace sql query of `matched_payment_requests` to query builder

* fix: replace `locals` with `get_doc` in set_query

* fix: changes during review

* fix: minor review changes

* fix: remove unnecessary code for setting payment entry received amount

* fix: logic for ser payment_request if PE made from transaction

* fix: Use rounded total to make Payment Request from `Sales Invoice` or `Purchase Invoice`

* refactor: enhance logic of `set_open_payment_requests_to_references`

* fix: added one optional arg `created_from_payment_request`

* fix: handle multiple allocation of PR at PE's reference

* fix: logic for PR if outstanding docs fetch

* fix: formatted Link field for `Payment Request` for PE's references

* fix: replace `get_all()` with `get_list()` for getting Payment Request for Link field

* fix: replace `get_all()` with `get_list()` for getting Payment Request for Link field

* chore: format `payment_entry.js` file

* style: Show preview popup of `Payment Request`

* fix: remove minor bug

* fix: add virtual field for Payment Term and Request `outstanding_amount` in PE's reference

* fix: get outstanding amount in PE's reference on realtime

* fix: move allocation of allocated_amount to server side (no change)

* fix: some minor changes to allocation

* fix: Split `Payment Request` if PE is created from PR and there are `Payment Terms`

* fix: minor logic changes

* fix: Allocation of allocated_amount if `paid_amount` is changes

* fix: improve logic of allocation

* fix: set matched payment request if unset

* fix: minor changes

* fix: Allocate single Payment Request if PE created from PR

* fix: improve code logic

* fix: Removed duplication code

* fix: proper message title

* refactor: Rename method of Allocation Amount to References

* refactor: Changing `grand_total` description based on `party_type`

* refactor: update Payment Request

* fix: Remove virtual property of payment_term_oustanding from references

* fix: fetch party account currency for creating payment request

* fix: use transaction currency as base in payment request

* fix: party amount for creating payment entry

* fix: allow for proportional amount paid by bank

* fix: Changed field order in Payment Request

* fix: Minor refactor in Payment Entry Reference table data

* test: Added test cases for allow Payment at `Partially Paid` status for PR

* test: Update partial paid status test case

* test: Update test case for same currency PR

* refactor: Wider the `msgprint` dialog for after save PE

* test: Update PR test cases

* chore: Remove dirty lines

* test: Checking `Advance Payment Status`

* fix: formatting update

* fix: Use `flt` where doing subtraction

* test: PR test case with Payment Term for same currency

* fix: remove redundant `flt`

* test: Add test cases for PR

---------

Co-authored-by: Sagar Vora <[email protected]>
@ruthra-kumar
Copy link
Member

@Abdeali099
Could you update the description?

Advance Payment Status is not in v15, but the commit messages in the description could mislead developers.

@Abdeali099
Copy link
Contributor Author

@Abdeali099 Could you update the description?

Advance Payment Status is not in v15, but the commit messages in the description could mislead developers.

Updated..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants