-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Calculate monthly repayment precisely to the fraction of a currency unit, turning rounding up into an optional feature. #36
base: develop
Are you sure you want to change the base?
Conversation
8e60efd
to
012e6cb
Compare
9897f38
to
3cd35c0
Compare
A few failing tests, no big deal, but nice we have coverage! |
…ncy, turning rounding up into an optional feature.
3cd35c0
to
8ba2a31
Compare
The business logic related test fails need to be tackled in the end, that’s fine, these basically is the feature rather than a bug, though of course both need to be tested to work right:
But these other update_after_submit related fails are almost driving me crazy:
We shouldn‘t be changing anything on update after submit. I tried almost everything without any success. But specifically for updates after submit, in This stubborn problem now cost me more time and nerves than all of the actual feature. I would be really grateful for some advise how to tackle this, @deepeshgarg007 or @anandbaburajan or someone else who happened to hit a similar problem. Thank you so much! 🙏 |
Before:
Now also possible:
And this is how it works, UI-wise:
RPReplay_Final1695066171.mov
Fixes #31. Includes some minor UI improvements and some minor refactoring of related code.
Full Loan Repayment Schedules for comparison:
Before.pdf
With PR (rounded up).pdf
With PR (to the cent).pdf