Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gluon-core: Split check-site.lua and Introduce Lua Module: gluon.validation #2927

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

lemoer
Copy link
Member

@lemoer lemoer commented Jul 15, 2023

This is a preparatory step. The newly introduced validation class is to be used within the REST API later on.

@github-actions github-actions bot added the 3. topic: package Topic: Gluon Packages label Jul 15, 2023
@lemoer
Copy link
Member Author

lemoer commented Jul 19, 2023

Ok, the build seems to fail since opkg on the host system currently can not find the gluon.validator lib.

However, I think we can already do a first review here. @mkg20001 Can you do that?

@mkg20001
Copy link
Member

...target-x86_64_musl/root-x86/lib/gluon/check-site.lua the check-site script is executed on the host. we'd need to make gluon.validator available in host's lua path via Host/Install phase or such.

Copy link
Member

@AiyionPrime AiyionPrime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually looks fine; but no approve without a green pipeline ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. topic: package Topic: Gluon Packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants