build: allow validating image-size of resulting images #3097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
3. topic: build
blocktrron
force-pushed
the
openwrt-profile-info
branch
from
6c01d24
to
821a7bc
Compare
T-X
reviewed
Dec 11, 2023
Copy the OpenWrt profiles.json file generated for each target to the output directory. Signed-off-by: David Bauer <[email protected]>
blocktrron
force-pushed
the
openwrt-profile-info
branch
from
85180f7
to
a7a1abc
Compare
neocturne
added
3. topic: continuous integration
and removed
3. topic: continous integration
labels
|
Interesting PR that I missed, thanks for showing it to me :) why is overhead set to 256 in particular?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull-Request adds the ability to check the resulting images from a Gluon build to be checked in terms of available image-size.
Gluon already fails in case an image is discarded due to exceeding the available size. However, this ignores the requirement of additional space for the jffs2 overlay.
Include the IMAGE_SIZE defined in OpenWrt into the profile.json. Also start copying this file to the Gluon output directory.
Add a script for validating the image-size with a customizable overhead.
Include this script into the CI action of Gluon.