Add JSON schema for output of reuse lint --json
#128
Conversation
| "licenses": { | ||
| "type": "array", | ||
| "items": { | ||
| "$ref": "#/definitions/Copyright" |
There was a problem hiding this comment.
Is the object name Copyright the correct name if it also used in a licensing context?
There was a problem hiding this comment.
What would be the alternative?
There was a problem hiding this comment.
Maybe Details or FindingDetails?
| "BadLicenses": { | ||
| "type": "object", | ||
| "additionalProperties": { "type": "object" }, | ||
| "title": "BadLicenses" | ||
| }, | ||
| "LicensesWithoutExtension": { | ||
| "type": "object", | ||
| "additionalProperties": { "type": "object" }, | ||
| "title": "LicensesWithoutExtension" | ||
| }, | ||
| "MissingLicenses": { | ||
| "type": "object", | ||
| "additionalProperties": { "type": "object" }, | ||
| "title": "MissingLicenses" | ||
| }, |
There was a problem hiding this comment.
If I understand it correctly these objects are not defined or explicitly structured.
There was a problem hiding this comment.
Yep, you're right. That's because the key of these objects is in a sense arbitrary, i.e. the license name. I don't know JSON schema well enough to know whether this can be alleviated. I think for a first version, this is fine though.
There was a problem hiding this comment.
Least we could do is force the keys to be strings https://stackoverflow.com/a/26848488
This addresses fsfe/reuse-tool#728.