Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateTime & TimeSpan Operation overloads #553

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DoganCK
Copy link

@DoganCK DoganCK commented Nov 25, 2022

Added operation overloads

  • Series<'K, DateTime> - DateTime -> Series<'K, TimeSpan>
  • DateTime - Series<'K, DateTime> -> Series<'K, TimeSpan>
  • Series<'K, DateTime> + TimeSpan -> Series<'K, DateTime>
  • Series<'K, DateTime> - TimeSpan -> Series<'K, DateTime>
  • TimeSpan + Series<'K, DateTime> -> Series<'K, DateTime>
  • Series<'K, TimeSpan> + TimeSpan -> Series<'K, TimeSpan>
  • Series<'K, TimeSpan> - TimeSpan -> Series<'K, TimeSpan>
  • TimeSpan + Series<'K, TimeSpan> -> Series<'K, TimeSpan>
  • TimeSpan - Series<'K, TimeSpan> -> Series<'K, TimeSpan>
  • Series<'K, TimeSpan> + Series<'K, TimeSpan> -> Series<'K, TimeSpan>
  • Series<'K, TimeSpan> - Series<'K, TimeSpan> -> Series<'K, TimeSpan>

Added functions

  • ScalarGenericOperationL<'T1, 'T2, ‘T3>
  • ScalarGenericOperationR<'T1, 'T2, ‘T3>

I also wanted to add vector operations on DateTime & TimeSpan like:

  • Series<'K, DateTime> - Series<'K, DateTime> -> Series<'K, TimeSpan>
  • Series<'K, DateTime> - Series<'K, TimeSpan> -> Series<'K, DateTime>

However, I was unable to figure out issues concerning BoxedVectors and writing a generic Vector Operation capable of handling different argument or return types.

Maybe there's a simpler solution for this. Any pointers would be appreciated.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant