Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use std::lock_guard instead of std::unique_lock #3179

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

wsehjk
Copy link
Contributor

@wsehjk wsehjk commented Sep 11, 2024

I think overrun_counter, size, and reset_overrun_counter func don't need the flexibility of std::unique_lock, it's better to use std::lock_guard with minimal overhead;

@wsehjk wsehjk changed the title DRAFT: use std::lock_guard instead of std::unique_lock use std::lock_guard instead of std::unique_lock Sep 11, 2024
@gabime gabime merged commit 2169a6f into gabime:v1.x Sep 11, 2024
8 checks passed
@gabime
Copy link
Owner

gabime commented Sep 11, 2024

Merged. Thanks @wsehjk

@wsehjk wsehjk deleted the dev_lock_guard branch September 12, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants