Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update QuPath ROIsplitter to v0.3.2 #773

Merged

Conversation

npinter
Copy link
Contributor

@npinter npinter commented Sep 2, 2024

The update fixes a problem with the filling of ROIs.

@bgruening
Copy link
Member

Please check your Python code, you are mixing tabs and spaces I think :)

Also the test is falling with:

Expected file size of 459919+-0 found 1309478

Is the filesize change expected?

@npinter
Copy link
Contributor Author

npinter commented Sep 2, 2024

Please check your Python code, you are mixing tabs and spaces I think :)

Also the test is falling with:

Expected file size of 459919+-0 found 1309478

Is the filesize change expected?

I'm more of a tab guy :( I wasn't aware that this was a linting issue.

@bgruening
Copy link
Member

Python guidelines. I recommend using black and put this into your editor by default.

@bgruening bgruening merged commit 80eecd9 into galaxyproteomics:master Sep 2, 2024
11 checks passed
@npinter npinter deleted the update-qupath-roi-splitter branch September 2, 2024 18:58
@npinter
Copy link
Contributor Author

npinter commented Sep 2, 2024

ty! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants