Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadonlyArray Difference Prefer Non-Deprecated #1826

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JLambertazzo
Copy link

@JLambertazzo JLambertazzo commented Jan 25, 2023

Prefer Non-Deprecated Function Signature for ReadonlyArray Difference

Currently there two function signatures for the difference function in the ReadonlyArray module and one is deprecated. Typescript seems to give preference to the deprecated signature as shown here:
Screenshot_20230124_083241

This PR changes the order of the signatures, prioritizing the non-deprecated signature:
Screenshot_20230124_083322

Before submitting a pull request, please make sure the following is done:

  • Fork the repository and create your branch from master.
  • Run npm install in the repository root.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Ensure the test suite passes (npm test).

Note. If you've fixed a bug please link the related issue or, if missing, open an issue before sending a PR.

#1804

Note. If you find a typo in the documentation, make sure to modify the corresponding source (docs are generated).

Note. If you want to send a PR related to [email protected] please create your branch from 1.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant