Fixes liferay#1393 If data-style attribute is not a valid JSON a exce…

…ption will be thrown and the code will stop working
georgel-pop-lr · May 18, 2020 · a1c1452 · a1c1452
1 parent 8404706
commit a1c1452
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/src/plugins/embedurl.js b/src/plugins/embedurl.js
@@ -406,11 +406,19 @@ if (!CKEDITOR.plugins.get('embedurl')) {
 
 					// Sync dimensions and alignment with editor wrapper
 
+					let styles = null;
+
 					const stylesJSON = instance.element.getAttribute(
 						'data-styles'
 					);
 
-					let styles = stylesJSON ? JSON.parse(stylesJSON) : null;
+					if (stylesJSON) {
+						try {
+							styles = JSON.parse(stylesJSON);
+						} catch (e) {
+							console.warn('Unable to parse data-styles attribute!');
+						}
+					}
 
 					if (!styles) {
 						const iframe = instance.wrapper.findOne('iframe');