geozero-shp release with deprecation message #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
approved these changes
Aug 28, 2024
michaelkirk
requested changes
Aug 29, 2024
There was a problem hiding this comment.
Can you include a module level declaration so that people can see it in their compiler output, since people often don't read documentation:
Something like:
#![deprecated(note = "The geozero_shp crate has been deprecated. Instead, use geozero's built-in shapefile feature")]
michaelkirk
reviewed
Aug 29, 2024
| @@ -1,7 +1,7 @@ | |||
| [package] | |||
| name = "geozero-shp" | |||
| version = "0.5.0" | |||
There was a problem hiding this comment.
Suggested change
| version = "0.5.0" | |
| version = "0.5.1" |
I think this should be a patch bump - we're not breaking anything right?
|
Test fails because of clippy complaints... Will force merge it when both PRs are ready. |
michaelkirk
approved these changes
Aug 30, 2024
|
Note to self: Release to crates.io just after next geozero release! |
|
Will we have to pin to a specific (old) version of geozero for this geozero_shp release? Currently it's using "workspace" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be released & merged before #233