Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 404 Page when theme not found #777

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Conversation

mr4tt
Copy link
Contributor

@mr4tt mr4tt commented Jul 27, 2024

No description provided.

Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this contribution, @mr4tt! I made a few minor suggestions. Would you please let me know if I can clarify any of those comments?

I love the Pelican illustration you drew and deeply appreciate you donating this illustration to the project. Much appreciated! 🫶

.gitignore Outdated Show resolved Hide resolved
requirements.txt Outdated Show resolved Hide resolved
@mr4tt
Copy link
Contributor Author

mr4tt commented Jul 28, 2024

That makes sense! I've made the changes, and I'm glad you like the pelican! :)

@justinmayer justinmayer changed the title Adding 404 Page when theme not found Add 404 Page when theme not found Jul 30, 2024
Copy link
Member

@justinmayer justinmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the follow-up changes, @mr4tt. I made a few minor additional tweaks.

Once again, I really appreciate the contribution and the wonderful illustration. You rock! 🥇

@justinmayer justinmayer merged commit ef37632 into getpelican:master Jul 30, 2024
@mr4tt
Copy link
Contributor Author

mr4tt commented Jul 30, 2024

Oh, I forgot to mention this was part of #768 !
This can now be closed too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants