-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alchemy for large accounts #1278
base: master
Are you sure you want to change the base?
Conversation
onemicky
commented
Sep 30, 2024
•
edited by xhiroz
Loading
edited by xhiroz
- To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1208263214312296
✅ Deploy Preview for vigilant-albattani-df38ec ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying gmx-interface with Cloudflare Pages
|
const LARGE_ACCOUNT_CHAINS = [ARBITRUM, AVALANCHE]; | ||
|
||
export function useAccountVolumeStats(params: { account?: string; enabled?: boolean }) { | ||
const { account, enabled = true } = params; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enabled
seems to be always true, you think it will be needed in the nearest future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, removed this props
src/lib/rpc/bestRpcTracker.ts
Outdated
@@ -79,7 +83,7 @@ function trackRpcProviders({ warmUp = false } = {}) { | |||
const hasMultipleProviders = Object.keys(providers).length > 1; | |||
const isUnusedChain = | |||
!lastUsage || differenceInMilliseconds(Date.now(), lastUsage) > DISABLE_UNUSED_TRACKING_TIMEOUT; | |||
const isChainTrackingEnabled = (warmUp || !isUnusedChain) && hasMultipleProviders; | |||
const isChainTrackingEnabled = !isLargeAccount && (warmUp || !isUnusedChain) && hasMultipleProviders; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this part of requirements wasn't implemented:
If paid RPC does not work, usual logic of RPC selection must be used (competitive selection, switching, etc, including free RPCs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My initial thought was that after the last ABs, we proved Alchemy is reliable and don't need this 'fallback for fallback.' However, after syncing with G, it became clear that it's better to do it.
Thank you for highlighting this point.