Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add type definitions #50

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

feat: add type definitions #50

wants to merge 4 commits into from

Conversation

unional
Copy link

@unional unional commented Apr 19, 2020

Adding TypeScript type definitions to the library.

@hatched hatched mentioned this pull request Apr 21, 2020
Open
@hatched
Copy link
Collaborator

hatched commented Apr 21, 2020

Thanks for this PR!

I just wanted to let you know that I've seen this and will get to it as soon as I can.

In response to your question on #49 We'd definitely be interested in converting this to TS, I've created an issue to hold discussions around this topic #53

@unional
Copy link
Author

unional commented Apr 21, 2020

I have a TS version in my fork. I'll do some clean up and then file a PR . :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unional @hatched