Educational: built-in map primitive
#1093
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leads to simplification in type inference since the construction of a `TabLam` (that was previously the single argument of `Map`) is no longer required there.
apaszke
reviewed
Oct 4, 2022
| TabPi (TabPiType (_:>ixTy) _) <- getType array' | ||
| buildTabLam noHint ixTy \i -> do | ||
| locals <- tabApp (sink ans) $ Var i | ||
| ithArg <- emitAtomToName =<< (tabApp (sink array') $ Var i) |
There was a problem hiding this comment.
Instead of emitting to name, you could b @> SubstVal ithArg below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is educational work.
DO NOT MERGE.
Implement a built-in
mapprimitive for mapping a function over an array.The concrete syntax for the implemented
mapprimitive ismap_ <function> over_ <array>. Example:map_ (\x. 2 * x) over_ [0, 1, 2, 3]will evaluate to[0, 2, 4, 6].