Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use multiple threads for running tests in CI #692

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

apaszke
Copy link
Collaborator

@apaszke apaszke commented Nov 22, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label Nov 22, 2021
@oxinabox
Copy link
Contributor

For reference, right now Hosted Github Actions runners are always:

  • 2 core for Windows/Linux
  • 3 core for Mac

https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

The code here gives some future proofing against that changing.
And would also allow private runners, that were different.

@apaszke
Copy link
Collaborator Author

apaszke commented Nov 23, 2021

Yeah I know the specs are public, but I want to avoid eyeballing them. This seemed like a more robust solution.

The downside is that we might be getting some space leaks, because the jobs seem to be running out of memory now...

@apaszke apaszke changed the base branch from safe-names-dev to main March 4, 2022 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants