Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Issue in the extension URL extracted using profile loader #2475

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vbothe23
Copy link
Contributor

@vbothe23 vbothe23 commented Mar 14, 2024

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #[issue number]
#2029

Description
Issue:
When using structure definition based extraction with ProfileLoader, the questionnaireItem definition URL was added in the extension instead of the profile URL.

Fix:
When adding custom definition based extension to the resource in the ResourceMapper, the extension URL is now fetched the ElementDefinition in the given profile.

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Bug fix

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

@vbothe23 vbothe23 changed the title Get profile url from the element definition. Fix: Issue in the extension URL extracted using profile loader Mar 14, 2024
@vbothe23 vbothe23 force-pushed the vb/fix-extension-extraction-issue branch from 671c232 to 8f8d58a Compare March 21, 2024 05:29
@vbothe23 vbothe23 force-pushed the vb/fix-extension-extraction-issue branch 2 times, most recently from 1f9e5c8 to e80a6ec Compare April 18, 2024 09:25
@vbothe23 vbothe23 force-pushed the vb/fix-extension-extraction-issue branch from e80a6ec to 9644dd5 Compare April 22, 2024 10:53
@vbothe23 vbothe23 force-pushed the vb/fix-extension-extraction-issue branch 2 times, most recently from d6f66d1 to c00bb0d Compare May 2, 2024 09:29
@vbothe23 vbothe23 force-pushed the vb/fix-extension-extraction-issue branch 2 times, most recently from f4fdc7d to 6623301 Compare May 13, 2024 06:25
@vbothe23 vbothe23 force-pushed the vb/fix-extension-extraction-issue branch from 6623301 to 53065e5 Compare May 20, 2024 06:22
@MJ1998
Copy link
Collaborator

MJ1998 commented May 21, 2024

Hey @vbothe23 thanks for this PR.
Is this issue blocking you guys ?

@vbothe23 vbothe23 force-pushed the vb/fix-extension-extraction-issue branch from 53065e5 to f573f05 Compare May 22, 2024 05:48
@vbothe23
Copy link
Contributor Author

Hi @MJ1998,
This issue is currently not blocking our workflow, but it does needs to be fixed. I am still working on this PR. Initially I observed only the incorrect URL in the extension and made necessary changes. However, I noticed that extension data type also seems incorrect when extracted using ProfileLoader, especially for the value of type CodeableConcept.
I will mark this PR as ready for review after I fix that.

@vbothe23 vbothe23 marked this pull request as ready for review May 22, 2024 10:08
@vbothe23 vbothe23 marked this pull request as draft May 22, 2024 10:09
@vbothe23 vbothe23 force-pushed the vb/fix-extension-extraction-issue branch from f573f05 to d001d14 Compare May 30, 2024 09:03
@vbothe23 vbothe23 force-pushed the vb/fix-extension-extraction-issue branch from d001d14 to 6555287 Compare July 11, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

2 participants