This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Remove GeneralDiscoverable flag #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the BLE spec (Volume 3, Part C, Section 9.1.1.2), the GeneralDiscoverable flag shouldn't be set for Broadcast devices (which Eddystone should apparently be, when in beacon-advertising mode). As far as I can tell, this is just used for filtering scan results on the host. I've tested it on Android and iOS and it still works.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
I have signed it. |
|
Good |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the BLE spec (Volume 3, Part C, Section 9.1.1.2), the GeneralDiscoverable flag shouldn't be set for Broadcast devices (which Eddystone should apparently be, when in beacon-advertising mode).
As far as I can tell, this is just used for filtering scan results on the host. I've tested it on Android and iOS and it still works.