-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kvm: set MSR_IA32_SPEC_CTRL to the host value #10805
Open
avagin
wants to merge
1
commit into
google:master
Choose a base branch
from
avagin:kvm-msr-spec-ctrl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avagin
added
platform: kvm
Issue related to the kvm platform
arch: x86_64
Issue related to the x86_64 achitecture
area: platform
Issue related to platforms (kvm, ptrace)
labels
Aug 22, 2024
avagin
force-pushed
the
kvm-msr-spec-ctrl
branch
2 times, most recently
from
August 22, 2024 00:54
2d9f87c
to
f48476b
Compare
Otherwise, the kernel needs to save/restore the value of this msr on each vmexit/vmenter. Here are kvm benchmark results: goarch: amd64 cpu: 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz Before: BenchmarkWorldSwitchToUserRoundtrip-8 1605484 3644 ns/op After: BenchmarkWorldSwitchToUserRoundtrip-8 1812069 3255 ns/op Signed-off-by: Andrei Vagin <[email protected]>
avagin
force-pushed
the
kvm-msr-spec-ctrl
branch
from
August 22, 2024 01:38
f48476b
to
7e9a33a
Compare
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
Otherwise, the kernel needs to save/restore the value of this msr on each vmexit/vmenter. Here are kvm benchmark results: goarch: amd64 cpu: 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz Before: Before: BenchmarkWorldSwitchToUserRoundtrip-8 1605484 3644 ns/op After: BenchmarkWorldSwitchToUserRoundtrip-8 1812069 3255 ns/op FUTURE_COPYBARA_INTEGRATE_REVIEW=#10805 from avagin:kvm-msr-spec-ctrl 7e9a33a PiperOrigin-RevId: 666429086
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
Otherwise, the kernel needs to save/restore the value of this msr on each vmexit/vmenter. Here are kvm benchmark results: goarch: amd64 cpu: 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz Before: Before: BenchmarkWorldSwitchToUserRoundtrip-8 1605484 3644 ns/op After: BenchmarkWorldSwitchToUserRoundtrip-8 1812069 3255 ns/op FUTURE_COPYBARA_INTEGRATE_REVIEW=#10805 from avagin:kvm-msr-spec-ctrl 7e9a33a PiperOrigin-RevId: 666429086
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
Otherwise, the kernel needs to save/restore the value of this msr on each vmexit/vmenter. Here are kvm benchmark results: goarch: amd64 cpu: 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz Before: Before: BenchmarkWorldSwitchToUserRoundtrip-8 1605484 3644 ns/op After: BenchmarkWorldSwitchToUserRoundtrip-8 1812069 3255 ns/op FUTURE_COPYBARA_INTEGRATE_REVIEW=#10805 from avagin:kvm-msr-spec-ctrl 7e9a33a PiperOrigin-RevId: 666429086
copybara-service bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
Otherwise, the kernel needs to save/restore the value of this msr on each vmexit/vmenter. Here are kvm benchmark results: goarch: amd64 cpu: 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz Before: Before: BenchmarkWorldSwitchToUserRoundtrip-8 1605484 3644 ns/op After: BenchmarkWorldSwitchToUserRoundtrip-8 1812069 3255 ns/op FUTURE_COPYBARA_INTEGRATE_REVIEW=#10805 from avagin:kvm-msr-spec-ctrl 7e9a33a PiperOrigin-RevId: 666429086
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
arch: x86_64
Issue related to the x86_64 achitecture
area: platform
Issue related to platforms (kvm, ptrace)
platform: kvm
Issue related to the kvm platform
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the kernel needs to save/restore the value of this msr on each vmexit/vmenter.
Here are kvm benchmark results:
goarch: amd64
cpu: 11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz Before:
BenchmarkWorldSwitchToUserRoundtrip-8 1394972 4103 ns/op
After:
BenchmarkWorldSwitchToUserRoundtrip-8 1528820 3770 ns/op