build.yml “Don't run this on every push ('on' param)” #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…' param)” The purpose of this line is to run only when we create a release, which is a tag. I'm assuming these are created in github somehow; if that assumption isn't true, we may need to use on: push: tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this line is to run (ie, build wheels) only when we create a release, which is a tag. I'm assuming these release tags are created in github somehow; if that assumption isn't true, we may need to use
on: push: tagsinstead.In my own manual testing, this definitely prevented
Build wheelsfrom running on every push. Whether it also allowsBuild wheelsto run at the right times is a little less certain, and depends on how this project is run. It runsBuild wheelswhen I create a new tag in github! It also runsBuild wheelswhen I create a new branch in github, but I don't think there's any way to prevent that; but that seems harmless enough.