Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore): Replace legacy header google-cloud-resource-prefix with x-goog-request-params #24490

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SandeepTuniki
Copy link
Contributor

@SandeepTuniki SandeepTuniki commented Jan 29, 2024

This PR replaces the legacy header google-cloud-resource-prefix with the preferred header x-goog-request-params. See this (internal) for more info.

Note: Firestore doesn't yet accept the header value of x-goog-request-params in the format projects/{project_id/databases/{database_id}. So this PR shouldn't be merged until the backend release (see here).

Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@SandeepTuniki SandeepTuniki added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2024
@SandeepTuniki SandeepTuniki added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2024
@SandeepTuniki SandeepTuniki changed the title Test PR - Evaluate legacy header replacement in Firestore fix(firestore): Replace legacy header google-cloud-resource-prefix with x-goog-request-params Jan 29, 2024
@SandeepTuniki SandeepTuniki marked this pull request as ready for review January 29, 2024 08:59
@SandeepTuniki SandeepTuniki added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 29, 2024
@product-auto-label product-auto-label bot added the api: firestore Issues related to the Firestore API. label Jan 29, 2024
@SandeepTuniki
Copy link
Contributor Author

SandeepTuniki commented Feb 8, 2024

The backend now accepts the x-goog-request-params header in the new format, but the emulator doesn't support it yet. Waiting for it to be fixed. Track here (internal).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the Firestore API. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants