Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging options to Helm chart #1691

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Baarsgaard
Copy link
Contributor

@Baarsgaard Baarsgaard commented Sep 24, 2024

Expose available logging options in the Helm chart.
Useful for people who use structured logging solutions.
I found #1659 and thought it would be a quick fix.

I also found some securityContext options that were not replicated to/from the kustomize configuration, those were aligned along with the logging args.

Replication steps:

# Prepare kind cluster
export KUBECONFIG=~/.kube/kind-grafana-operator
make kind-start

# Install Helm chart with no modifications
helm upgrade -i grafana-operator ./deploy/helm/grafana-operator --version v5.13.0

# Verify default configurations
kubectl get deployments.apps grafana-operator -o yaml | grep -A 10 containers:
# Verify standard/default log output
kubectl logs deployments/grafana-operator

# Install helm chart with overwritten logging values
helm upgrade -i grafana-operator ./deploy/helm/grafana-operator --version v5.13.0 \
  --set logging.encoder=json --set logging.level=debug --set logging.time=rfc3339

# Verify arg changes in deployment
kubectl get deployments.apps grafana-operator -o yaml | grep -A 10 containers:
# Verify level, encoding, and time format have changed in the logs
kubectl logs deployments/grafana-operator

@Baarsgaard Baarsgaard marked this pull request as ready for review September 24, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant