Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc-js-xds: Make legacy interop script use proto-loader correctly #2702

Merged

Conversation

murgatroid99
Copy link
Member

#2700 changed grpc-js and grpc-js-xds dev builds to use the local proto-loader installation for faster test turnaround on protobuf TypeScript code generation changes. That PR included changes to the Dockerfile to handle that local usage correctly. This change does the same thing for the legacy test script.

@sergiitk
Copy link
Member

sergiitk commented Mar 29, 2024

@sergiitk
Copy link
Member

The test failed with Exception: Wrong number of UNARY_CALL RPCs in-flight: actual(782) < expected(800 - 1%), but it's irrelevant - the build succeeded.

@murgatroid99 murgatroid99 merged commit 77dca7a into grpc:master Mar 29, 2024
9 of 10 checks passed
@sergiitk
Copy link
Member

sergiitk commented Apr 3, 2024

ref b/331625445

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants