Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Herobrine1010 #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

herobrine1010
Copy link

Content of this update:

  1. Denoised some character pictures.

  2. Added "fall" sound for all characters and "dropped" sound for some characters. To make sure that "dropped" sound would not be covered, soundPlaying.destroy()(line 181 in file state.ts) is also commented out. The original code of the latest version reserving this function would interrupt any overlapping sound, thus making the design of "dropped" invalid.

    Actually, though not hanging up a clip before letting another start may bring about chaotic effect in terms of sound, I would still suggest doing so. Allowing the sound to overlap is also necessary for further updates on options such as background music.

    All clips are from bestdori, and the original clips seems too loud at volume=0.5. I altered it to 0.4.

  3. Added corresponding voice clip of band name on clearing each group. "band-data.ts" is also added, which works like "character-data.ts".

  4. Added Hagumi's croquette as falling item.

  5. Added some image assets in path "./src/asset/objects" for future use, such as bands' logos, coronet-throwing Rimi and some else. These are not yet applied in this update.

1. Denoised some character pictures.

2. Added "fall" sound for all characters and "dropped" sound for some characters. To make sure that "dropped" sound would not be covered, `soundPlaying.destroy()`(line 181 in file state.ts) is also commented out. The original code of the latest version reserving this function would interrupt any overlapping sound, thus making the design of "dropped" invalid.

   Actually, though not hanging up a clip before letting another start may bring about chaotic effect in terms of sound, I would still suggest doing so. Allowing the sound to overlap is also necessary for further updates on options such as background music.

   All clips are from bestdori.com, and the original clips seems too loud at volume=0.5. I altered it to 0.4.

3. Added corresponding voice clip of band name on clearing each group. "band-data.ts" is also added, which works like "character-data.ts".

4. Added Hagumi's croquette as falling item.

5. Added some image assets in path "./src/asset/objects" for future use, such as bands' logos, coronet-throwing Rimi and some else. These are not yet applied in this update.
1. Denoised some character pictures.

2. Added "fall" sound for all characters and "dropped" sound for some characters. To make sure that "dropped" sound would not be covered, `soundPlaying.destroy()`(line 181 in file state.ts) is also commented out. The original code of the latest version reserving this function would interrupt any overlapping sound, thus making the design of "dropped" invalid.

   Actually, though not hanging up a clip before letting another start may bring about chaotic effect in terms of sound, I would still suggest doing so. Allowing the sound to overlap is also necessary for further updates on options such as background music.

   All clips are from bestdori.com, and the original clips seems too loud at volume=0.5. I altered it to 0.4.

3. Added corresponding voice clip of band name on clearing each group. "band-data.ts" is also added, which works like "character-data.ts".

4. Added Hagumi's croquette as falling item.

5. Added some image assets in path "./src/asset/objects" for future use, such as bands' logos, coronet-throwing Rimi and some else. These are not yet applied in this update.
@hamzaabamboo
Copy link
Owner

Hello Herobrine ! First of all , thank you for contributing to pazuru-pico.
That's a lot of code and new assets right there !
I tried your code and I think it works really well.
Before merging, can you run the format script and make a commit again ?
using npm run format or yarn format

@herobrine1010
Copy link
Author

herobrine1010 commented Oct 27, 2020 via email

@herobrine1010
Copy link
Author

herobrine1010 commented Oct 27, 2020 via email

@hamzaabamboo
Copy link
Owner

Sorry for late reply, I am kinda busy lately.
No problem for the formatting, I will sort it out after merge.
I'll merge this soon.

@herobrine1010
Copy link
Author

herobrine1010 commented Nov 3, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants