Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add friendship_status method #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add friendship_status method #50

wants to merge 2 commits into from

Conversation

rickygu
Copy link

@rickygu rickygu commented Oct 16, 2017

Add the ability to check friendship status between two friends.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 99.393% when pulling 9f2b605 on rickygu:master into 83368e8 on sungwoncho:master.

chevinbrown
chevinbrown suggested changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@chevinbrown chevinbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please provide test coverage?

@chevinbrown
Copy link
Contributor

@rickygu 👋 thanks for your contribution!

Would you mind if I cherry-picked these commits so we can add it to upstream with tests?

@Frexuz
Copy link

Frexuz commented Jun 17, 2021

🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chevinbrown chevinbrown chevinbrown requested changes

Assignees
No one assigned
Labels
Needs Revision
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rickygu @coveralls @chevinbrown @Frexuz