Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary .proto files #27

Merged

Conversation

rwalworth
Copy link
Contributor

Description:
This PR fixes an issue caused by including unnecessary .proto files in the build. Files were getting overwritten and causing issues adding features to the C++ SDK.

Related issue(s):

Fixes #26

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@rwalworth rwalworth added the Bug A error that causes the feature to behave differently than what was expected based on design docs label Jul 17, 2023
@rwalworth rwalworth requested a review from deyanzz July 17, 2023 19:45
@rwalworth rwalworth self-assigned this Jul 17, 2023
@rwalworth rwalworth linked an issue Jul 17, 2023 that may be closed by this pull request
Copy link
Contributor

@deyanzz deyanzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rwalworth rwalworth merged commit 76f7530 into main Jul 18, 2023
3 checks passed
@rwalworth rwalworth deleted the 00026-incorrect-consensus_serviceproto-file-is-being-installed branch July 18, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect consensus_service.proto file is being installed
2 participants