Make genericSerial generic over Integral #534
Open
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmicklas
reviewed
Jan 10, 2021
| @@ -183,7 +183,7 @@ instance FieldReturnType 'True 'False Sqlite resTy a => | |||
| field' _ _ nm ty _ collation constraints SqliteHasDefault = | |||
| field' (Proxy @'True) (Proxy @'False) nm ty Nothing collation constraints | |||
|
|
|||
| instance BeamSqlBackendHasSerial Sqlite where | |||
| instance (Integral n) => BeamSqlBackendHasSerial n Sqlite where | |||
There was a problem hiding this comment.
This should have a IsSqliteSerialIntegerType constraint.
| @@ -452,5 +452,5 @@ instance Db.FieldReturnType 'True 'False Postgres resTy a => | |||
| field' _ _ nm ty _ collation constraints PgHasDefault = | |||
| Db.field' (Proxy @'True) (Proxy @'False) nm ty Nothing collation constraints | |||
|
|
|||
| instance BeamSqlBackendHasSerial Postgres where | |||
| instance (Integral n) => BeamSqlBackendHasSerial n Postgres where | |||
There was a problem hiding this comment.
This instance should be split for Int16, Int32, and Int64 and use smallserial, serial, and bigserial, respectively.
| BeamSqlBackendHasSerial be where | ||
| genericSerial :: FieldReturnType 'True 'False be (SqlSerial Int) a => Text -> a | ||
| class (BeamMigrateSqlBackend be, Integral n) => | ||
| BeamSqlBackendHasSerial n be where |
There was a problem hiding this comment.
I'd be in favor of removing the Integral constraint here. Integral implies Num which implies the ability to do arithmetic. However, I can imagine wanting to add support for an opaque ID type which prohibits arithmetic. Backends already have the ability to constrain the valid ns in their instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested on #532