Add warnings and fallback for unassigned devices in infer_auto_device_map #3066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/accelerate/utils/modeling.py
Outdated
| @@ -1465,6 +1469,13 @@ def infer_auto_device_map( | |||
| f"offload_buffers=True." | |||
| ) | |||
|
|
|||
| for device, mem in device_minimum_assignment_memory.items(): | |||
There was a problem hiding this comment.
This has the potential to spam a lot of warnings. How about creating a single message and only warn once?
There was a problem hiding this comment.
Thanks for pointing that out! I have addressed the issue in my new commit.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
src/accelerate/utils/modeling.py
Outdated
| f"Based on the current allocation process, no modules could be assigned to the following devices due to" | ||
| f"insufficient memory:\n" | ||
| f"{devices_info}\n" | ||
| f"These minimum requirements are specific to this allocation attempt and may vary. Consider increasing" |
There was a problem hiding this comment.
Suggested change
| f"These minimum requirements are specific to this allocation attempt and may vary. Consider increasing" | |
| f"These minimum requirements are specific to this allocation attempt and may vary. Consider increasing " |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is proposed changes to the infer_auto_device_map function from #3041. It will make the following improvements:
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.