fix: incorrect variable naming causing crash (#220)

* ci: avoid multiple typescript-eslint instances * fix: use API instead of fetch * fix: camelCase name
ietf-tools · Sep 24, 2024 · 5983b48 · 5983b48
1 parent d07342f
commit 5983b48
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 11 deletions.
diff --git a/client/components/DocumentCard.vue b/client/components/DocumentCard.vue
@@ -41,7 +41,8 @@ Based on https://tailwindui.com/components/application-ui/lists/grid-lists#compo
       <div class="flex justify-between gap-x-4 py-3">
         <dt class="text-gray-500">Deadline</dt>
         <dd class="grow flex items-start gap-x-2">
-          {{ cookedDocument.external_deadline?.toLocaleString(DateTime.DATE_FULL) || '-' }}</dd>
+          {{ cookedDocument.externalDeadline?.toLocaleString(DateTime.DATE_FULL) || '-' }}
+        </dd>
       </div>
       <div class="flex justify-between gap-x-4 py-3">
         <dt class="text-gray-500">Pages</dt>
@@ -61,7 +62,8 @@ Based on https://tailwindui.com/components/application-ui/lists/grid-lists#compo
                 class="flex flex-row gap-1 items-center relative w-full cursor-default rounded-lg bg-white py-2 pl-3 pr-1 text-left shadow-md focus:outline-none focus-visible:border-indigo-500 focus-visible:ring-2 focus-visible:ring-white focus-visible:ring-opacity-75 focus-visible:ring-offset-2 focus-visible:ring-offset-orange-300 sm:text-sm"
               >
                 <div class="flex-auto ">
-                  <div v-for="person in uniqBy(cookedDocument.assignmentsPersons, person => person?.id)" :key="person?.id">
+                  <div v-for="person in uniqBy(cookedDocument.assignmentsPersons, person => person?.id)"
+                       :key="person?.id">
                     {{ person.name }}
                   </div>
                 </div>
@@ -175,7 +177,7 @@ const cookedDocument = computed(() => {
 
   return ({
     ...props.document,
-    external_deadline: props.document.externalDeadline && DateTime.fromJSDate(props.document.externalDeadline),
+    externalDeadline: props.document.externalDeadline && DateTime.fromJSDate(props.document.externalDeadline),
     assignments: props.document.assignments,
     assignmentsPersons,
     assignmentsPersonIds: assignmentsPersons?.map(editor => editor?.id),

diff --git a/client/components/DocumentCardsTypes.ts b/client/components/DocumentCardsTypes.ts
@@ -1,7 +1,7 @@
 export interface DocumentCardType {
   id: string
   name: string
-  external_deadline: string
+  externalDeadline: string
   needsAssignment?: {
     name: string
   }

diff --git a/client/eslint.config.mjs b/client/eslint.config.mjs
@@ -2,15 +2,12 @@ import vue from 'eslint-plugin-vue'
 import globals from 'globals'
 import parser from 'vue-eslint-parser'
 import eslint from '@eslint/js'
-import tseslint from 'typescript-eslint'
 import neostandard from 'neostandard'
 import withNuxt from './.nuxt/eslint.config.mjs'
 
 export default withNuxt(
   ...neostandard(),
-  eslint.configs.recommended,
-  ...tseslint.configs.recommended,
-  ...tseslint.configs.stylistic, {
+  eslint.configs.recommended, {
     plugins: {
       vue
     },

diff --git a/client/pages/docs/assignments.vue b/client/pages/docs/assignments.vue
@@ -68,7 +68,7 @@
 
 <script setup lang="ts">
 import type { ResolvedDocument, ResolvedPerson } from '~/components/AssignmentsTypes'
-import type { Assignment, RfcToBe, RpcPerson } from '~/rpctracker_client'
+import type { Assignment, RfcToBe, RpcPerson, RpcRole } from '~/rpctracker_client'
 import { DateTime } from 'luxon'
 
 const csrf = useCookie('csrftoken', { sameSite: 'strict' })
@@ -175,7 +175,11 @@ async function refresh () {
 
 // DATA RETRIEVAL
 
-const { data: people, pending: pendingPeople, refresh: refreshPeople } = await useFetch<RpcPerson[]>('/api/rpc/rpc_person/', { baseURL: '/', server: false })
+const { data: people, pending: pendingPeople, refresh: refreshPeople } = await useAsyncData<RpcPerson[]>(
+  'rpcPersons',
+  () => api.rpcPersonList(),
+  { server: false, default: () => ([]) }
+)
 
 const { data: rfcsToBe, pending: pendingDocs, refresh: refreshDocs } = await useAsyncData<RfcToBe[]>(
   'rfcsToBe',
@@ -187,7 +191,7 @@ const {
   pending: pendingAssignments,
   refresh: refreshAssignments
 } = await useFetch<Assignment[]>('/api/rpc/assignments/', { baseURL: '/', server: false })
-const { data: roles } = await useAsyncData(
+const { data: roles } = await useAsyncData<RpcRole[]>(
   'roles',
   async () => {
     try {
@@ -198,6 +202,7 @@ const { data: roles } = await useAsyncData(
         title: 'Unable to list roles',
         text: e
       })
+      return []
     }
   },
   { default: () => ([]) }