Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Break word when line overflows #1021

Merged
merged 3 commits into from
Aug 4, 2023
Merged

fix: Break word when line overflows #1021

merged 3 commits into from
Aug 4, 2023

Conversation

kesara
Copy link
Member

@kesara kesara commented Aug 3, 2023

When a word is too big to fit in a line in HTML and PDF outputs, break the word.

Fixes #687

jennifer-richards
jennifer-richards approved these changes Aug 3, 2023
View reviewed changes
Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is fine, maybe change commit message to "when line overflows" instead of "when the overlap" for clarity?

@kesara kesara changed the title fix: Break word when the overlap fix: Break word when line overflows Aug 3, 2023
@kesara
Copy link
Member Author

kesara commented Aug 3, 2023

Code is fine, maybe change commit message to "when line overflows" instead of "when the overlap" for clarity?

I have updated the commit message.

@kesara
fix: Break word when line overflows
ba8311f 
When a word is too big to fit in a line in HTML and PDF outputs,
break the word.

Fixes ietf-tools#687
@kesara
chore: Run yestests
41ea4c6
@kesara
chore: Run yestests with fix
a0b1c40
@kesara kesara merged commit 43c82f0 into ietf-tools:main Aug 4, 2023
12 checks passed
@kesara kesara deleted the fix/word-wrap branch August 4, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennifer-richards jennifer-richards jennifer-richards approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Text in HTML/PDF not wrapping properly
2 participants
@kesara @jennifer-richards