Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth48 #515

Draft
wants to merge 27 commits into
base: main
Choose a base branch
from
Draft

Auth48 #515

wants to merge 27 commits into from

Conversation

cabo
Copy link
Member

@cabo cabo commented Feb 12, 2024

Files for completing AUTH48 process

@cabo cabo requested a review from glyn February 12, 2024 14:29
Copy link
Collaborator

@glyn glyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure of the intended use of this. Is it mainly a base for applying XML changes? Is the content equivalent to the current level from the RFC editors? It looks like many of the files are generated from the XML, presumably just to give a more granular way of viewing changes.

Should we now create PRs relative to the auth48 branch? Not sure how to do that. Clearly, I can (at least in principle) edit the XML, but how to generate the rest?

@cabo
Copy link
Member Author

cabo commented Feb 12, 2024 via email

@@ -449,7 +449,7 @@ $.store.book[[email protected] < 10].title
| `..name` | shorthand for `..['name']` |
| `..*` | shorthand for `..[*]` |
| `'name'` | [name selector](#name-selector): selects a named child of an object |
| `*` | [wildcard selector](#name-selector): selects all children of a node |
| `*` | [wildcard selector](#wildcard-selector): selects all children of a node |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cabo Good catch!

Copy link
Collaborator

@glyn glyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes up to G10 looking good, thanks!

note that we don't have a definition for a sole "argument", but that
is a standard term that has very little confusion attached to it.
Copy link
Collaborator

@glyn glyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another good set of changes, thanks, up to G1.

What became of G11?

Copy link
Collaborator

@glyn glyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All approved. Thanks!

@glyn
Copy link
Collaborator

glyn commented Feb 13, 2024

Another good set of changes, thanks, up to G1.

What became of G11?

I dropped G11 after discussion.

@gregsdennis
Copy link
Collaborator

@cabo do you have a link for the auth48 process and what these files are for? I thought auth48 was just final author approvals.

@cabo
Copy link
Member Author

cabo commented Feb 14, 2024

Hi Greg,

there is not a single document I could point to.
GPT-4 says:

The Auth48 process for IETF standards is specified in several documents, but the main ones are:

RFC 2026: The Internet Standards Process -- Revision 3. This document covers the general standards process at IETF, including the final AUTH48 review state when a draft becomes a full Internet Standard.
The IETF's official "Guidelines to Authors of Internet-Drafts", also called "Guidelines to Authors."
The IETF's official "Guidelines to Working Group Chairs," which also mentions the AUTH48 process.
In addition, the IETF Trust's "Legal Provisions Relating to IETF Documents" include guidelines for authors during the AUTH48 review period.

In summary, AUTH48 is for checking the RFC Production Center (RPC) edits between authors and RPC and making any editorial and technical changes necessary before publication. Since this is an approved document, any technical changes will be quite limited (essentially inconsequential for interoperability in this case).

@gregsdennis
Copy link
Collaborator

So why all the new files? What's the driver for these?

I don't expect any technical changes, but I'm curious about the new files.

@cabo
Copy link
Member Author

cabo commented Feb 14, 2024

The new files come from a script, check-abnf, that just checks whether any of the spacing fixes we made to the ABNF actually changed its contents. They are extracted from the XML via kramdown-rfc-extract-sourcecode. I was lazy and comitted all of those, even if I only care about the ABNF.

Copy link
Collaborator

@gregsdennis gregsdennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation, @cabo

Copy link
Collaborator

@glyn glyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5c10c5a LGTM, thanks.

@@ -72,7 +72,7 @@
<name>Introduction</name>
<t>JSON <xref target="RFC8259"/> is a popular representation
format for structured data values.
JSONPath defines a string syntax for selecting and extracting JSON <xref target="RFC8259"/> values
JSONPath defines a string syntax for selecting and extracting JSON values
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that was a bit much!

Copy link
Collaborator

@glyn glyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C4 and C5 LGTM, thanks!

(We can't verify what was deprecated in 2014, which was 5 years after
ES5 was released, replacing the ES4 proposal stalled in development.)
Copy link
Collaborator

@glyn glyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C6, C1, C7 are good.

The word "strict" is used nowhere else but table 11.
It serves no useful purpose here.
(It might have been meant to distinguish strict inequalities (<) from
non-strict (<=) ones, but extracting that intention is too much of a
transfer for the reader.)
Copy link
Collaborator

@glyn glyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C8 is just what I would have done.

The text in 2.4.8 (value()) apparently wasn't updated when we stopped
talking about "Nothing" for nodelists (these are now simply "empty").
Copy link
Collaborator

@glyn glyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C9 was a corker. Thanks for fixing.

@cabo
Copy link
Member Author

cabo commented Feb 15, 2024

I'm now planning to keep this as a draft pull request until the RFC is published.
Then I'll have a look if the published version can be back-ported to the .md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants