EXP-660: Fix priority comparison

indeedeng · Jun 11, 2024 · a9ea605 · a9ea605
1 parent dee4dab
commit a9ea605
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/proctor-common/src/main/java/com/indeed/proctor/common/Proctor.java b/proctor-common/src/main/java/com/indeed/proctor/common/Proctor.java
@@ -561,13 +561,17 @@ private void attemptStoringProperty(
             final PayloadExperimentConfig newPayloadConfig =
                     testChoosers.get(testName).getTestDefinition().getPayloadExperimentConfig();
             // store property if it has higher priority than the currently stored property
-            if (isHigherPriority(currPayloadConfig, newPayloadConfig)) {
-                testProperties.put(
-                        field.getKey(),
-                        PayloadProperty.builder()
-                                .value(field.getValue())
-                                .testName(testName)
-                                .build());
+            try {
+                if (isHigherPriority(currPayloadConfig, newPayloadConfig)) {
+                    testProperties.put(
+                            field.getKey(),
+                            PayloadProperty.builder()
+                                    .value(field.getValue())
+                                    .testName(testName)
+                                    .build());
+                }
+            } catch (final NumberFormatException e) {
+                LOGGER.error("Failed to parse priority value to Long: ", e);
             }
         }
     }

diff --git a/proctor-common/src/main/java/com/indeed/proctor/common/model/PayloadExperimentConfig.java b/proctor-common/src/main/java/com/indeed/proctor/common/model/PayloadExperimentConfig.java
@@ -38,6 +38,7 @@ public static boolean isHigherPriority(
                 && payloadConfig.getPriority() != null
                 && otherPayloadConfig != null
                 && otherPayloadConfig.getPriority() != null
-                && payloadConfig.getPriority().compareTo(otherPayloadConfig.getPriority()) < 0;
+                && Long.parseLong(payloadConfig.getPriority())
+                        < Long.parseLong(otherPayloadConfig.getPriority());
     }
 }