PROC-1444: Fix check

indeedeng · Feb 29, 2024 · f7c321a · f7c321a
1 parent 5508c89
commit f7c321a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/proctor-common/src/main/java/com/indeed/proctor/common/RuleEvaluator.java b/proctor-common/src/main/java/com/indeed/proctor/common/RuleEvaluator.java
@@ -23,6 +23,7 @@
 import javax.el.ValueReference;
 import javax.el.VariableMapper;
 import java.util.Map;
+import java.util.Objects;
 
 /**
  * A nice tidy packaging of javax.el stuff.
@@ -172,7 +173,7 @@ static void checkRuleIsBooleanType(
         Class<?> type = ve.getType(elContext);
 
         // if object is map check what the base value type is
-        if (type.equals(Object.class)) {
+        if (Objects.equals(type, Object.class)) {
             final ValueReference valueReference = ve.getValueReference(elContext);
             final Object base = valueReference.getBase();
             final Object property = valueReference.getProperty();

diff --git a/proctor-common/src/test/java/com/indeed/proctor/common/TestRuleEvaluator.java b/proctor-common/src/test/java/com/indeed/proctor/common/TestRuleEvaluator.java
@@ -212,11 +212,6 @@ public void testElExpressionsShouldBeAvailableNestedMap() {
         }
     }
 
-    @Test
-    public void testDummy() {
-        assertFalse(Object.class.equals(Map.class));
-    }
-
     @Test
     public void testElExpressionsShouldBeAvailableNestedMapErrors() {
         final Map<String, Map<String, String>> traits =