feat(telemetry): static values, cpu and mem metrics gathering #25380
Conversation
praveen-influx
force-pushed
the
praveen/telemetry-static-values
branch
14 times, most recently
from
b223b2c
to
301ac6c
Compare
| tokio::spawn(async move { | ||
| let telem_sender = TelemetrySender::new( | ||
| reqwest::Client::new(), | ||
| "https://telemetry.influxdata.foo.com".to_owned(), |
There was a problem hiding this comment.
This getting updated in a follow on PR?
There was a problem hiding this comment.
Yes - this will be updated in one of the follow on PRs
praveen-influx
force-pushed
the
praveen/telemetry-static-values
branch
from
301ac6c
to
a5ae662
Compare
praveen-influx
force-pushed
the
praveen/telemetry-static-values
branch
from
a5ae662
to
b1ce43f
Compare
praveen-influx
force-pushed
the
praveen/telemetry-static-values
branch
from
b1ce43f
to
d99c15d
Compare
| num_cpus: usize, | ||
| ) -> Arc<TelemetryStore> { | ||
| let os = std::env::consts::OS; | ||
| let influxdb_pkg_version = env!("CARGO_PKG_VERSION"); |
There was a problem hiding this comment.
@praveen-influx - sorry didn't catch this during review, but I think it would be worth re-using from the influxdb3_process workspace crate for some of these environment variables.
There was a problem hiding this comment.
I can use it for the version as built here.
I'll probably need other lookup for the package name CARGO_PKG_NAME - is it worth adding that lookup to the influxdb3_process crate as well?
There was a problem hiding this comment.
is it worth adding that lookup to the influxdb3_process crate as well?
I think it would be appropriate. It sounds like we may also need to make some adjustments in influxdb3_process for differentiating Pro vs. OSS but that is TBD pending discussion with the perf team by the looks of it.
Closes: #25370, #25371