fix: caching lookup to behave correctly when inputs/output mapping #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericcraw
changed the title
ericcraw
changed the title
sfatimar
reviewed
Sep 24, 2024
| } else { | ||
| // Does this make sense for both types of allocators? | ||
| ort_tensor_key_t ort_tensor_key{input_name}; | ||
| auto it = ort_ov_tensor_map.find(ort_tensor_key); |
There was a problem hiding this comment.
when are we first inserting the values in the map ? if (it != ort_ov_tensor_map.end() || it->second.ort_ptr != tensor.GetTensorRawData())
sfatimar
reviewed
Sep 24, 2024
| // Does this make sense for both types of allocators? | ||
| ort_tensor_key_t ort_tensor_key{input_name}; | ||
| auto it = ort_ov_tensor_map.find(ort_tensor_key); | ||
| if (it != ort_ov_tensor_map.end() || it->second.ort_ptr != tensor.GetTensorRawData()) { |
There was a problem hiding this comment.
the first condition will always be false
sfatimar
reviewed
Sep 24, 2024
| ov_tensor_data.tensor_ptr = std::make_shared<ov::Tensor>(input.get_element_type(), input.get_shape(), | ||
| (void*)tensor.GetTensorRawData()); | ||
| ov_tensor_data.ort_ptr = tensor.GetTensorRawData(); | ||
| ort_ov_tensor_map[ort_tensor_key] = ov_tensor_data; |
There was a problem hiding this comment.
do we even need to specify the ORT_NPU_ALLOCATOR anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context