Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Manaverse #2298

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from
Draft

Feat: Manaverse #2298

wants to merge 5 commits into from

Conversation

hmoog
Copy link
Contributor

@hmoog hmoog commented Jun 21, 2022

Description of change

This PR implements the scheduler for the experimental manaverse tokenomics.

Type of change

  • Enhancement (a non-breaking change which adds functionality)

Change checklist

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@hmoog hmoog marked this pull request as draft June 22, 2022 11:08
jcburuchaga
jcburuchaga reviewed Jan 25, 2023
View reviewed changes
packages/tangle/message.go

// Compare is a comparator for Blocks.
func (m *Message) Compare(other *Message) int {
if m.BurnedMana() < other.BurnedMana() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in bucket compare, used a switch, why not here? please maintain code style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcburuchaga jcburuchaga jcburuchaga left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hmoog @jcburuchaga