Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make base64 encoding target independent in KeyIdMemStore in wasm bindings #1386

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

wulfraem
Copy link
Contributor

@wulfraem wulfraem commented Jun 27, 2024

Description of change

Makes base64 encoding in KeyIdMemStore, methodDigestToString work for node and web targets. By using new dependency base64-arraybuffer.

Also adds smaller improvements for storage related errors.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Tested in browser and against local wasm tests.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@wulfraem wulfraem added Wasm Related to Wasm bindings. Becomes part of the Wasm changelog Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog Rust Related to the core Rust code. Becomes part of the Rust changelog. labels Jun 27, 2024
@wulfraem wulfraem marked this pull request as ready for review June 27, 2024 14:16
@wulfraem wulfraem requested a review from a team as a code owner June 27, 2024 14:16
@eike-hass eike-hass removed the Rust Related to the core Rust code. Becomes part of the Rust changelog. label Jun 27, 2024
@eike-hass eike-hass self-requested a review June 27, 2024 16:06
@eike-hass eike-hass merged commit bb13b38 into main Jun 27, 2024
20 checks passed
@eike-hass eike-hass deleted the fix/make-base64-encoding-target-independent branch June 27, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Patch Change without affecting the API that requires a patch release. Part of "Patch" section in changelog Wasm Related to Wasm bindings. Becomes part of the Wasm changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants