Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Fix custom_time feature ci tests #1400

Closed
wants to merge 12 commits into from
Closed

Conversation

itsyaasir
Copy link
Contributor

This PR adds a feature to identity_core to allow specifying a custom
function to get the current time (Timestamp::now_utc).
The feature is disabled by default.

Closes #1391.# Description of change
Please write a summary of your changes and why you made them.

Links to any relevant issues

Be sure to reference any related issues by adding fixes issue #.

Type of change

Add an x to the boxes that are relevant to your changes.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This PR adds a feature to `identity_core` to allow specifying a custom
function to get the current time (`Timestamp::now_utc`).
The feature is disabled by default.

Closes #1391.
Also removes the unused dependency on `iota-crypto` (which also had
a dependency on `js-sys` through the `random` feature).
@itsyaasir itsyaasir requested a review from a team as a code owner August 27, 2024 12:42
@itsyaasir itsyaasir added Chore Tedious, typically non-functional change No changelog Excludes PR from becoming part of any changelog labels Aug 27, 2024
@itsyaasir itsyaasir closed this Aug 30, 2024
@itsyaasir itsyaasir deleted the fix/custom-time-ci branch August 30, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Tedious, typically non-functional change No changelog Excludes PR from becoming part of any changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Remove (or make optional) dependency on time (Timestamp::now_utc())
2 participants