Add support for custom JWS algorithms #1410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces a feature `custom_alg` to `identity_jose` (disabled by default) that allows it to process JWS with custom `alg` values. Switching on `custom_alg` makes quite a few changes to `JwsAlgorithm`: - The type is no longer `Copy` - `name()` takes only a reference and returns a `String` rather than `&'static str` - The constant `ALL` is removed as it is no longer possible to enumerate all variants
|
@itsyaasir, @eike-hass: The change using a feature flag seems to be quite reasonable. What do you think? |
frederikrothenberger
force-pushed
the
frederik/custom-alg
branch
from
eb35981
to
a7cdda4
Compare
eike-hass
added
Added
itsyaasir
approved these changes
Sep 16, 2024
wulfraem
approved these changes
Sep 17, 2024
|
Thanks for this @frederikrothenberger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a feature
custom_algtoidentity_jose(disabled by default) that allows it to process JWS with customalgvalues.Switching on
custom_algmakes quite a few changes toJwsAlgorithm:Copyname()takes only a reference and returns aStringrather than&'static strALLis removed as it is no longer possible to enumerate all variantsFixes issue #1406.
Type of change
Add an
xto the boxes that are relevant to your changes.How the change has been tested
Added a new integration test to
identity_josethat exercises the functionality.Note: requires CI changes to be run with
cargo test --test custom_alg --features="custom_alg"Change checklist
Add an
xto the boxes that are relevant to your changes.