removed min commission rate

docs/core/proto-docs.md

@@ -6766,7 +6766,6 @@ Params defines the parameters for the staking module.
 | `max_entries` | [uint32](#uint32) |  | max_entries is the max entries for either unbonding delegation or redelegation (per pair/trio). |
 | `historical_entries` | [uint32](#uint32) |  | historical_entries is the number of historical entries to persist. |
 | `bond_denom` | [string](#string) |  | bond_denom defines the bondable coin denomination. |
-| `min_commission_rate` | [string](#string) |  | min_commission_rate is the chain-wide minimum commission rate that a validator can charge their delegators |
 | `validator_bond_factor` | [string](#string) |  | validator_bond_factor is required as a safety check for tokenizing shares and delegations from liquid staking providers |
 | `global_liquid_staking_cap` | [string](#string) |  | global_liquid_staking_cap represents a cap on the portion of stake that comes from liquid staking providers |
 | `validator_liquid_staking_cap` | [string](#string) |  | validator_liquid_staking_cap represents a cap on the portion of stake that comes from liquid staking providers for a specific validator |

proto/cosmos/staking/v1beta1/staking.proto

@@ -308,29 +308,23 @@ message Params {
   uint32 historical_entries = 4 [(gogoproto.moretags) = "yaml:\"historical_entries\""];
   // bond_denom defines the bondable coin denomination.
   string bond_denom = 5 [(gogoproto.moretags) = "yaml:\"bond_denom\""];
-  // min_commission_rate is the chain-wide minimum commission rate that a validator can charge their delegators
-  string min_commission_rate = 6 [
-    (gogoproto.moretags)   = "yaml:\"min_commission_rate\"",
-    (gogoproto.customtype) = "github.com/cosmos/cosmos-sdk/types.Dec",
-    (gogoproto.nullable)   = false
-  ];
   // validator_bond_factor is required as a safety check for tokenizing shares and
   // delegations from liquid staking providers
-  string validator_bond_factor = 7 [
+  string validator_bond_factor = 6 [
     (gogoproto.moretags)   = "yaml:\"validator_bond_factor\"",
     (gogoproto.customtype) = "github.com/cosmos/cosmos-sdk/types.Dec",
     (gogoproto.nullable)   = false
   ];
   // global_liquid_staking_cap represents a cap on the portion of stake that
   // comes from liquid staking providers
-  string global_liquid_staking_cap = 8 [
+  string global_liquid_staking_cap = 7 [
     (gogoproto.moretags)   = "yaml:\"global_liquid_staking_cap\"",
     (gogoproto.customtype) = "github.com/cosmos/cosmos-sdk/types.Dec",
     (gogoproto.nullable)   = false
   ];
   // validator_liquid_staking_cap represents a cap on the portion of stake that
   // comes from liquid staking providers for a specific validator
-  string validator_liquid_staking_cap = 9 [
+  string validator_liquid_staking_cap = 8 [
     (gogoproto.moretags)   = "yaml:\"validator_liquid_staking_cap\"",
     (gogoproto.customtype) = "github.com/cosmos/cosmos-sdk/types.Dec",
     (gogoproto.nullable)   = false

x/staking/client/testutil/suite.go

@@ -895,15 +895,14 @@ global_liquid_staking_cap: "1.000000000000000000"
 historical_entries: 10000
 max_entries: 7
 max_validators: 100
-min_commission_rate: "0.000000000000000000"
 unbonding_time: 1814400s
 validator_bond_factor: "-1.000000000000000000"
 validator_liquid_staking_cap: "1.000000000000000000"`,
 		},
 		{
 			"with json output",
 			[]string{fmt.Sprintf("--%s=json", tmcli.OutputFlag)},
-			`{"unbonding_time":"1814400s","max_validators":100,"max_entries":7,"historical_entries":10000,"bond_denom":"stake","min_commission_rate":"0.000000000000000000","validator_bond_factor":"-1.000000000000000000","global_liquid_staking_cap":"1.000000000000000000","validator_liquid_staking_cap":"1.000000000000000000"}`,
+			`{"unbonding_time":"1814400s","max_validators":100,"max_entries":7,"historical_entries":10000,"bond_denom":"stake","validator_bond_factor":"-1.000000000000000000","global_liquid_staking_cap":"1.000000000000000000","validator_liquid_staking_cap":"1.000000000000000000"}`,
 		},
 	}
 	for _, tc := range testCases {

x/staking/keeper/msg_server.go

@@ -2,7 +2,6 @@ package keeper
 
 import (
 	"context"
-	"errors"
 	"fmt"
 	"strconv"
 	"time"
@@ -41,10 +40,6 @@ func (k msgServer) CreateValidator(goCtx context.Context, msg *types.MsgCreateVa
 		return nil, err
 	}
 
-	if msg.Commission.Rate.LT(k.MinCommissionRate(ctx)) {
-		return nil, sdkerrors.Wrapf(errors.New("commission cannot be less than min rate"), "cannot set validator commission to less than minimum rate of %s", k.MinCommissionRate(ctx))
-	}
-
 	// check to see if the pubkey or sender has been registered before
 	if _, found := k.GetValidator(ctx, valAddr); found {
 		return nil, types.ErrValidatorOwnerExists

x/staking/keeper/params.go

@@ -47,12 +47,6 @@ func (k Keeper) PowerReduction(ctx sdk.Context) sdk.Int {
 	return sdk.DefaultPowerReduction
 }
 
-// MinCommissionRate - Minimum validator commission rate
-func (k Keeper) MinCommissionRate(ctx sdk.Context) (res sdk.Dec) {
-	k.paramstore.Get(ctx, types.KeyMinCommissionRate, &res)
-	return
-}
-
 // Validator bond factor for all validators
 func (k Keeper) ValidatorBondFactor(ctx sdk.Context) (res sdk.Dec) {
 	k.paramstore.Get(ctx, types.KeyValidatorBondFactor, &res)
@@ -79,7 +73,6 @@ func (k Keeper) GetParams(ctx sdk.Context) types.Params {
 		k.MaxEntries(ctx),
 		k.HistoricalEntries(ctx),
 		k.BondDenom(ctx),
-		k.MinCommissionRate(ctx),
 		k.ValidatorBondFactor(ctx),
 		k.GlobalLiquidStakingCap(ctx),
 		k.ValidatorLiquidStakingCap(ctx),

x/staking/keeper/validator.go

@@ -142,10 +142,6 @@ func (k Keeper) UpdateValidatorCommission(ctx sdk.Context,
 		return commission, err
 	}
 
-	if newRate.LT(k.MinCommissionRate(ctx)) {
-		return commission, fmt.Errorf("cannot set validator commission to less than minimum rate of %s", k.MinCommissionRate(ctx))
-	}
-
 	commission.Rate = newRate
 	commission.UpdateTime = blockTime
 

x/staking/keeper/validator_test.go

@@ -1045,11 +1045,6 @@ func TestUpdateValidatorCommission(t *testing.T) {
 	app, ctx, _, addrVals := bootstrapValidatorTest(t, 1000, 20)
 	ctx = ctx.WithBlockHeader(tmproto.Header{Time: time.Now().UTC()})
 
-	// Set MinCommissionRate to 0.05
-	params := app.StakingKeeper.GetParams(ctx)
-	params.MinCommissionRate = sdk.NewDecWithPrec(5, 2)
-	app.StakingKeeper.SetParams(ctx, params)
-
 	commission1 := types.NewCommissionWithTime(
 		sdk.NewDecWithPrec(1, 1), sdk.NewDecWithPrec(3, 1),
 		sdk.NewDecWithPrec(1, 1), time.Now().UTC().Add(time.Duration(-1)*time.Hour),
@@ -1074,7 +1069,6 @@ func TestUpdateValidatorCommission(t *testing.T) {
 		{val2, sdk.NewDecWithPrec(-1, 1), true},
 		{val2, sdk.NewDecWithPrec(4, 1), true},
 		{val2, sdk.NewDecWithPrec(3, 1), true},
-		{val2, sdk.NewDecWithPrec(1, 2), true},
 		{val2, sdk.NewDecWithPrec(2, 1), false},
 	}
 

x/staking/simulation/genesis.go

@@ -43,7 +43,6 @@ func RandomizedGenState(simState *module.SimulationState) {
 		unbondTime                time.Duration
 		maxVals                   uint32
 		histEntries               uint32
-		minCommissionRate         sdk.Dec
 		validatorBondFactor       sdk.Dec
 		globalLiquidStakingCap    sdk.Dec
 		validatorLiquidStakingCap sdk.Dec
@@ -73,7 +72,6 @@ func RandomizedGenState(simState *module.SimulationState) {
 		7,
 		histEntries,
 		sdk.DefaultBondDenom,
-		minCommissionRate,
 		validatorBondFactor,
 		globalLiquidStakingCap,
 		validatorLiquidStakingCap,

x/staking/types/params.go

@@ -33,8 +33,6 @@ const (
 )
 
 var (
-	// DefaultMinCommissionRate is set to 0%
-	DefaultMinCommissionRate = sdk.ZeroDec()
 	// DefaultValidatorBondFactor is set to -1 (disabled)
 	DefaultValidatorBondFactor = sdk.NewDecFromInt(sdk.NewInt(-1))
 	// DefaultGlobalLiquidStakingCap is set to 100%
@@ -50,7 +48,6 @@ var (
 	KeyBondDenom                 = []byte("BondDenom")
 	KeyHistoricalEntries         = []byte("HistoricalEntries")
 	KeyPowerReduction            = []byte("PowerReduction")
-	KeyMinCommissionRate         = []byte("MinCommissionRate")
 	KeyValidatorBondFactor       = []byte("ValidatorBondFactor")
 	KeyGlobalLiquidStakingCap    = []byte("GlobalLiquidStakingCap")
 	KeyValidatorLiquidStakingCap = []byte("ValidatorLiquidStakingCap")
@@ -70,7 +67,6 @@ func NewParams(
 	maxEntries uint32,
 	historicalEntries uint32,
 	bondDenom string,
-	minCommissionRate sdk.Dec,
 	validatorBondFactor sdk.Dec,
 	globalLiquidStakingCap sdk.Dec,
 	validatorLiquidStakingCap sdk.Dec,
@@ -81,7 +77,6 @@ func NewParams(
 		MaxEntries:                maxEntries,
 		HistoricalEntries:         historicalEntries,
 		BondDenom:                 bondDenom,
-		MinCommissionRate:         minCommissionRate,
 		ValidatorBondFactor:       validatorBondFactor,
 		GlobalLiquidStakingCap:    globalLiquidStakingCap,
 		ValidatorLiquidStakingCap: validatorLiquidStakingCap,
@@ -96,7 +91,6 @@ func (p *Params) ParamSetPairs() paramtypes.ParamSetPairs {
 		paramtypes.NewParamSetPair(KeyMaxEntries, &p.MaxEntries, validateMaxEntries),
 		paramtypes.NewParamSetPair(KeyHistoricalEntries, &p.HistoricalEntries, validateHistoricalEntries),
 		paramtypes.NewParamSetPair(KeyBondDenom, &p.BondDenom, validateBondDenom),
-		paramtypes.NewParamSetPair(KeyMinCommissionRate, &p.MinCommissionRate, validateMinCommissionRate),
 		paramtypes.NewParamSetPair(KeyValidatorBondFactor, &p.ValidatorBondFactor, validateValidatorBondFactor),
 		paramtypes.NewParamSetPair(KeyGlobalLiquidStakingCap, &p.GlobalLiquidStakingCap, validateGlobalLiquidStakingCap),
 		paramtypes.NewParamSetPair(KeyValidatorLiquidStakingCap, &p.ValidatorLiquidStakingCap, validateValidatorLiquidStakingCap),
@@ -111,7 +105,6 @@ func DefaultParams() Params {
 		DefaultMaxEntries,
 		DefaultHistoricalEntries,
 		sdk.DefaultBondDenom,
-		DefaultMinCommissionRate,
 		DefaultValidatorBondFactor,
 		DefaultGlobalLiquidStakingCap,
 		DefaultValidatorLiquidStakingCap,
@@ -162,10 +155,6 @@ func (p Params) Validate() error {
 		return err
 	}
 
-	if err := validateMinCommissionRate(p.MinCommissionRate); err != nil {
-		return err
-	}
-
 	if err := validateValidatorBondFactor(p.ValidatorBondFactor); err != nil {
 		return err
 	}
@@ -259,22 +248,6 @@ func ValidatePowerReduction(i interface{}) error {
 	return nil
 }
 
-func validateMinCommissionRate(i interface{}) error {
-	v, ok := i.(sdk.Dec)
-	if !ok {
-		return fmt.Errorf("invalid parameter type: %T", i)
-	}
-
-	if v.IsNegative() {
-		return fmt.Errorf("minimum commission rate cannot be negative: %s", v)
-	}
-	if v.GT(sdk.OneDec()) {
-		return fmt.Errorf("minimum commission rate cannot be greater than 100%%: %s", v)
-	}
-
-	return nil
-}
-
 func validateValidatorBondFactor(i interface{}) error {
 	v, ok := i.(sdk.Dec)
 	if !ok {

x/staking/types/params_test.go

@@ -5,7 +5,6 @@ import (
 
 	"github.com/stretchr/testify/require"
 
-	sdk "github.com/cosmos/cosmos-sdk/types"
 	"github.com/cosmos/cosmos-sdk/x/staking/types"
 )
 
@@ -28,11 +27,4 @@ func Test_validateParams(t *testing.T) {
 
 	// default params have no error
 	require.NoError(t, params.Validate())
-
-	// validate mincommision
-	params.MinCommissionRate = sdk.NewDec(-1)
-	require.Error(t, params.Validate())
-
-	params.MinCommissionRate = sdk.NewDec(2)
-	require.Error(t, params.Validate())
 }