Address Feedback From PR Review

Signed-off-by: Mahad Zaryab <[email protected]>
jaegertracing · Sep 28, 2024 · ac8b608 · ac8b608
1 parent e62e8ea
commit ac8b608
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/cmd/jaeger/internal/extension/jaegerquery/server.go b/cmd/jaeger/internal/extension/jaegerquery/server.go
@@ -159,7 +159,6 @@ func (s *server) createMetricReader(host component.Host) (metricsstore.Reader, e
 }
 
 func (s *server) makeQueryOptions() *queryApp.QueryOptions {
-	// TODO handle TLS
 	return &s.config.QueryOptions
 }
 

diff --git a/cmd/query/app/flags.go b/cmd/query/app/flags.go
@@ -104,14 +104,12 @@ func (qOpts *QueryOptions) InitFromViper(v *viper.Viper, logger *zap.Logger) (*Q
 	if err != nil {
 		return qOpts, fmt.Errorf("failed to process gRPC TLS options: %w", err)
 	}
-	otelTLSCfg := tlsGrpc.ToOtelServerConfig()
-	qOpts.GRPC.TLSSetting = otelTLSCfg
+	qOpts.GRPC.TLSSetting = tlsGrpc.ToOtelServerConfig()
 	tlsHTTP, err := tlsHTTPFlagsConfig.InitFromViper(v)
 	if err != nil {
 		return qOpts, fmt.Errorf("failed to process HTTP TLS options: %w", err)
 	}
-	otelHTTPCfg := tlsHTTP.ToOtelServerConfig()
-	qOpts.HTTP.TLSSetting = otelHTTPCfg
+	qOpts.HTTP.TLSSetting = tlsHTTP.ToOtelServerConfig()
 	qOpts.BasePath = v.GetString(queryBasePath)
 	qOpts.UIConfig.AssetsPath = v.GetString(queryStaticFiles)
 	qOpts.UIConfig.LogAccess = v.GetBool(queryLogStaticAssetsAccess)