Prevent infinite/recursive tracing of gRPC storage #5979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldlb9527
force-pushed
the
fix-factory
branch
from
ce891d9
to
5ae15ad
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5979 +/- ##
==========================================
- Coverage 96.79% 96.78% -0.02%
==========================================
Files 348 348
Lines 16559 16563 +4
==========================================
+ Hits 16029 16031 +2
- Misses 342 343 +1
- Partials 188 189 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ldlb9527
force-pushed
the
fix-factory
branch
3 times, most recently
from
2754064
to
1f58769
Compare
yurishkuro
changed the title
ldlb9527
force-pushed
the
fix-factory
branch
2 times, most recently
from
f35efec
to
1cb3b7a
Compare
fixes: jaegertracing#5971 Signed-off-by: cx <[email protected]>
ldlb9527
force-pushed
the
fix-factory
branch
from
1cb3b7a
to
454e742
Compare
yurishkuro
reviewed
Sep 27, 2024
| // TODO needs to be joined with the metricsFactory | ||
| LeveledMeterProvider: func(_ configtelemetry.Level) metric.MeterProvider { | ||
| return noopmetric.NewMeterProvider() | ||
| }, | ||
| } | ||
| newClientFn := func(opts ...grpc.DialOption) (conn *grpc.ClientConn, err error) { | ||
| newClientFn := func(telSettings component.TelemetrySettings, opts ...grpc.DialOption) (conn *grpc.ClientConn, err error) { |
There was a problem hiding this comment.
Please elaborate on this part. In newRemoteStorage() you never modify telset when calling newClientFn twice, so why do you need to pass it vs. how it was passed already here via closure?
yurishkuro
reviewed
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #5971
I'm not sure if this is reasonable, so please let me know if there are any issues.