Allow registering BCE in CDI SE without discovery #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ladicek
approved these changes
May 21, 2024
|
Apparently the formatter doesn't like the file...? |
Eh, not just that, I merely forgot to push the rebased version which also adapts tests with dummy initializer impls. |
Ladicek
approved these changes
May 21, 2024
|
I've also added the specification text (just a mention of the method being there) and created a CDI TCK tracking issue (jakartaee/cdi-tck#585). |
Ladicek
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #813
Adds a new method to
SeContainerInitializerwhich allows users to register build compatible extensions (BCE) without the need for discovery.I am aware the
SeContainerInitializerhas two variants of theaddmethod for portable extensions (PE), one of which allows you to pass in pre-initialized PE.I intentionally skipped that for BCE as those were designed with stricter environments in mind. However, if there is need/want for this we can add it as well.